forks/RadioLibSmol
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[AX.25] Cppcheck fixes

Browse source
This commit is contained in:
jgromes 2025-01-18 17:48:57 +01:00
parent d4d98d37ce
commit dab2c3497c
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/protocols/AX25/AX25.cpp
View file

@ -14,7 +14,7 @@ AX25Frame::AX25Frame(const char* destCallsign, uint8_t destSSID, const char* src
} }
AX25Frame::AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, uint8_t* info, uint16_t infoLen) { AX25Frame::AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, const uint8_t* info, uint16_t infoLen) {
// destination callsign/SSID // destination callsign/SSID
memcpy(this->destCallsign, destCallsign, strlen(destCallsign)); memcpy(this->destCallsign, destCallsign, strlen(destCallsign));
this->destCallsign[strlen(destCallsign)] = '\0'; this->destCallsign[strlen(destCallsign)] = '\0';
@ -142,7 +142,7 @@ AX25Frame& AX25Frame::operator=(const AX25Frame& frame) {
return(*this); return(*this);
} }
int16_t AX25Frame::setRepeaters(char** repeaterCallsigns, uint8_t* repeaterSSIDs, uint8_t numRepeaters) { int16_t AX25Frame::setRepeaters(char** repeaterCallsigns, const uint8_t* repeaterSSIDs, uint8_t numRepeaters) {
// check number of repeaters // check number of repeaters
if((numRepeaters < 1) || (numRepeaters > 8)) { if((numRepeaters < 1) || (numRepeaters > 8)) {
return(RADIOLIB_ERR_INVALID_NUM_REPEATERS); return(RADIOLIB_ERR_INVALID_NUM_REPEATERS);

4
src/protocols/AX25/AX25.h
View file

@ -185,7 +185,7 @@ class AX25Frame {
\param info Information field, in the form of arbitrary binary buffer. \param info Information field, in the form of arbitrary binary buffer.
\param infoLen Number of bytes in the information field. \param infoLen Number of bytes in the information field.
*/ */
AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, uint8_t* info, uint16_t infoLen); AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, const uint8_t* info, uint16_t infoLen);
/*! /*!
\brief Copy constructor. \brief Copy constructor.
@ -211,7 +211,7 @@ class AX25Frame {
\param numRepeaters Number of repeaters, maximum is 8. \param numRepeaters Number of repeaters, maximum is 8.
\returns \ref status_codes \returns \ref status_codes
*/ */
int16_t setRepeaters(char** repeaterCallsigns, uint8_t* repeaterSSIDs, uint8_t numRepeaters); int16_t setRepeaters(char** repeaterCallsigns, const uint8_t* repeaterSSIDs, uint8_t numRepeaters);
/*! /*!
\brief Method to set receive sequence number. \brief Method to set receive sequence number.