From dab2c3497c95d4d0dfb557e1f5d8272218f58c27 Mon Sep 17 00:00:00 2001 From: jgromes Date: Sat, 18 Jan 2025 17:48:57 +0100 Subject: [PATCH] [AX.25] Cppcheck fixes --- src/protocols/AX25/AX25.cpp | 4 ++-- src/protocols/AX25/AX25.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/protocols/AX25/AX25.cpp b/src/protocols/AX25/AX25.cpp index 22e1220a..ad0e9916 100644 --- a/src/protocols/AX25/AX25.cpp +++ b/src/protocols/AX25/AX25.cpp @@ -14,7 +14,7 @@ AX25Frame::AX25Frame(const char* destCallsign, uint8_t destSSID, const char* src } -AX25Frame::AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, uint8_t* info, uint16_t infoLen) { +AX25Frame::AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, const uint8_t* info, uint16_t infoLen) { // destination callsign/SSID memcpy(this->destCallsign, destCallsign, strlen(destCallsign)); this->destCallsign[strlen(destCallsign)] = '\0'; @@ -142,7 +142,7 @@ AX25Frame& AX25Frame::operator=(const AX25Frame& frame) { return(*this); } -int16_t AX25Frame::setRepeaters(char** repeaterCallsigns, uint8_t* repeaterSSIDs, uint8_t numRepeaters) { +int16_t AX25Frame::setRepeaters(char** repeaterCallsigns, const uint8_t* repeaterSSIDs, uint8_t numRepeaters) { // check number of repeaters if((numRepeaters < 1) || (numRepeaters > 8)) { return(RADIOLIB_ERR_INVALID_NUM_REPEATERS); diff --git a/src/protocols/AX25/AX25.h b/src/protocols/AX25/AX25.h index c7678a3a..13499546 100644 --- a/src/protocols/AX25/AX25.h +++ b/src/protocols/AX25/AX25.h @@ -185,7 +185,7 @@ class AX25Frame { \param info Information field, in the form of arbitrary binary buffer. \param infoLen Number of bytes in the information field. */ - AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, uint8_t* info, uint16_t infoLen); + AX25Frame(const char* destCallsign, uint8_t destSSID, const char* srcCallsign, uint8_t srcSSID, uint8_t control, uint8_t protocolID, const uint8_t* info, uint16_t infoLen); /*! \brief Copy constructor. @@ -211,7 +211,7 @@ class AX25Frame { \param numRepeaters Number of repeaters, maximum is 8. \returns \ref status_codes */ - int16_t setRepeaters(char** repeaterCallsigns, uint8_t* repeaterSSIDs, uint8_t numRepeaters); + int16_t setRepeaters(char** repeaterCallsigns, const uint8_t* repeaterSSIDs, uint8_t numRepeaters); /*! \brief Method to set receive sequence number.