From ff520e2a15cfb111cf973da7ac23d9f77661f826 Mon Sep 17 00:00:00 2001
From: jgromes <jgromes@users.noreply.github.com>
Date: Fri, 20 Nov 2020 17:52:17 +0100
Subject: [PATCH] [SX127x] Added method to read version register (#204)

---
 keywords.txt                  | 1 +
 src/modules/SX127x/SX127x.cpp | 8 ++++++--
 src/modules/SX127x/SX127x.h   | 7 +++++++
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/keywords.txt b/keywords.txt
index 06932713..e117eec2 100644
--- a/keywords.txt
+++ b/keywords.txt
@@ -130,6 +130,7 @@ getTempRaw	KEYWORD2
 setRfSwitchPins	KEYWORD2
 forceLDRO	KEYWORD2
 autoLDRO	KEYWORD2
+getChipVersion	KEYWORD2
 
 # RF69-specific
 setAESKey	KEYWORD2
diff --git a/src/modules/SX127x/SX127x.cpp b/src/modules/SX127x/SX127x.cpp
index c6fa95a9..6635b71b 100644
--- a/src/modules/SX127x/SX127x.cpp
+++ b/src/modules/SX127x/SX127x.cpp
@@ -990,6 +990,10 @@ uint8_t SX127x::random() {
   return(randByte);
 }
 
+int16_t SX127x::getChipVersion() {
+  return(_mod->SPIgetRegValue(SX127X_REG_VERSION));
+}
+
 int8_t SX127x::getTempRaw() {
   int8_t temp = 0;
   uint8_t previousOpMode;
@@ -1116,7 +1120,7 @@ bool SX127x::findChip(uint8_t ver) {
     reset();
 
     // check version register
-    uint8_t version = _mod->SPIreadRegister(SX127X_REG_VERSION);
+    int16_t version = getChipVersion();
     if(version == ver) {
       flagFound = true;
     } else {
@@ -1126,7 +1130,7 @@ bool SX127x::findChip(uint8_t ver) {
         RADIOLIB_DEBUG_PRINT(F(" of 10 tries) SX127X_REG_VERSION == "));
 
         char buffHex[12];
-        sprintf(buffHex, "0x%02X", version);
+        sprintf(buffHex, "0x%04X", version);
         RADIOLIB_DEBUG_PRINT(buffHex);
         RADIOLIB_DEBUG_PRINT(F(", expected 0x00"));
         RADIOLIB_DEBUG_PRINTLN(ver, HEX);
diff --git a/src/modules/SX127x/SX127x.h b/src/modules/SX127x/SX127x.h
index 27bf3f6c..a42605e1 100644
--- a/src/modules/SX127x/SX127x.h
+++ b/src/modules/SX127x/SX127x.h
@@ -938,6 +938,13 @@ class SX127x: public PhysicalLayer {
    */
     uint8_t random();
 
+    /*!
+     \brief Read version SPI register. Should return SX1278_CHIP_VERSION (0x12) or SX1272_CHIP_VERSION (0x22) if SX127x is connected and working.
+
+     \returns Version register contents or \ref status_codes
+   */
+    int16_t getChipVersion();
+
 #ifndef RADIOLIB_GODMODE
   protected:
 #endif