forks/RadioLibSmol
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check for RADIOLIB_SPI_PARANOID = 1 rather than just defined (#883)

Browse source 
* Update BuildOpt.h to set RADIOLIB_SPI_PARANOID to 1 by default

* Update Module.cpp to check for RADIOLIB_SPI_PARANOID set to 1
This commit is contained in:
Jonathan Bennett 2023-11-27 11:45:18 -06:00 • committed by GitHub
parent b6f6718f1f
commit f4938ea585
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/BuildOpt.h
View file

@ -358,13 +358,13 @@
#endif #endif
/* /*
* Uncomment to enable "paranoid" SPI mode * Comment to disable "paranoid" SPI mode, or set RADIOLIB_SPI_PARANOID to 0
* Every write to an SPI register using SPI set function will be verified by a subsequent read operation. * Every write to an SPI register using SPI set function will be verified by a subsequent read operation.
* This improves reliability, but slightly slows down communication. * This improves reliability, but slightly slows down communication.
* Note: Enabled by default. * Note: Enabled by default.
*/ */
#if !defined(RADIOLIB_SPI_PARANOID) #if !defined(RADIOLIB_SPI_PARANOID)
#define RADIOLIB_SPI_PARANOID #define RADIOLIB_SPI_PARANOID 1
#endif #endif
/* /*

4
src/Module.cpp
View file

@ -75,7 +75,7 @@ int16_t Module::SPIsetRegValue(uint16_t reg, uint8_t value, uint8_t msb, uint8_t
uint8_t newValue = (currentValue & ~mask) | (value & mask); uint8_t newValue = (currentValue & ~mask) | (value & mask);
SPIwriteRegister(reg, newValue); SPIwriteRegister(reg, newValue);
#if defined(RADIOLIB_SPI_PARANOID) #if RADIOLIB_SPI_PARANOID
// check register value each millisecond until check interval is reached // check register value each millisecond until check interval is reached
// some registers need a bit of time to process the change (e.g. SX127X_REG_OP_MODE) // some registers need a bit of time to process the change (e.g. SX127X_REG_OP_MODE)
uint32_t start = this->hal->micros(); uint32_t start = this->hal->micros();
@ -240,7 +240,7 @@ int16_t Module::SPIwriteStream(uint8_t* cmd, uint8_t cmdLen, uint8_t* data, size
int16_t Module::SPIcheckStream() { int16_t Module::SPIcheckStream() {
int16_t state = RADIOLIB_ERR_NONE; int16_t state = RADIOLIB_ERR_NONE;
#if defined(RADIOLIB_SPI_PARANOID) #if RADIOLIB_SPI_PARANOID
// get the status // get the status
uint8_t spiStatus = 0; uint8_t spiStatus = 0;
uint8_t cmd = this->SPIstatusCommand; uint8_t cmd = this->SPIstatusCommand;