forks/RadioLibSmol
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Crypto] Fixed issues found by cppcheck

Browse source
This commit is contained in:
jgromes 2024-05-12 12:04:41 +01:00
parent 330f4e8fe1
commit dd9dc39f69
2 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/utils/Cryptography.cpp
View file

@ -82,7 +82,7 @@ void RadioLibAES128::generateCMAC(uint8_t* in, size_t len, uint8_t* cmac) {
delete[] buff;
}
bool RadioLibAES128::verifyCMAC(uint8_t* in, size_t len, uint8_t* cmac) {
bool RadioLibAES128::verifyCMAC(uint8_t* in, size_t len, const uint8_t* cmac) {
uint8_t cmacReal[RADIOLIB_AES128_BLOCK_SIZE];
this->generateCMAC(in, len, cmacReal);
for(size_t i = 0; i < RADIOLIB_AES128_BLOCK_SIZE; i++) {
@ -93,7 +93,7 @@ bool RadioLibAES128::verifyCMAC(uint8_t* in, size_t len, uint8_t* cmac) {
return(true);
}
void RadioLibAES128::keyExpansion(uint8_t* roundKey, uint8_t* key) {
void RadioLibAES128::keyExpansion(uint8_t* roundKey, const uint8_t* key) {
uint8_t tmp[4];
// the first round key is the key itself
@ -167,7 +167,7 @@ void RadioLibAES128::rotWord(uint8_t* word) {
}
}
void RadioLibAES128::addRoundKey(uint8_t round, state_t* state, uint8_t* roundKey) {
void RadioLibAES128::addRoundKey(uint8_t round, state_t* state, const uint8_t* roundKey) {
for(size_t row = 0; row < 4; row++) {
for(size_t col = 0; col < 4; col++) {
(*state)[row][col] ^= roundKey[(round * RADIOLIB_AES128_N_B * 4) + (row * RADIOLIB_AES128_N_B) + col];
@ -175,13 +175,13 @@ void RadioLibAES128::addRoundKey(uint8_t round, state_t* state, uint8_t* roundKe
}
}
void RadioLibAES128::blockXor(uint8_t* dst, uint8_t* a, uint8_t* b) {
void RadioLibAES128::blockXor(uint8_t* dst, const uint8_t* a, const uint8_t* b) {
for(uint8_t j = 0; j < RADIOLIB_AES128_BLOCK_SIZE; j++) {
dst[j] = a[j] ^ b[j];
}
}
void RadioLibAES128::blockLeftshift(uint8_t* dst, uint8_t* src) {
void RadioLibAES128::blockLeftshift(uint8_t* dst, const uint8_t* src) {
uint8_t ovf = 0x00;
for(int8_t i = RADIOLIB_AES128_BLOCK_SIZE - 1; i >= 0; i--) {
dst[i] = src[i] << 1;

14
src/utils/Cryptography.h
View file

@ -142,23 +142,23 @@ class RadioLibAES128 {
\param cmac CMAC to verify.
\returns True if valid, false otherwise.
*/
bool verifyCMAC(uint8_t* in, size_t len, uint8_t* cmac);
bool verifyCMAC(uint8_t* in, size_t len, const uint8_t* cmac);
private:
uint8_t* keyPtr;
uint8_t roundKey[RADIOLIB_AES128_KEY_EXP_SIZE];
uint8_t* keyPtr = nullptr;
uint8_t roundKey[RADIOLIB_AES128_KEY_EXP_SIZE] = { 0 };
void keyExpansion(uint8_t* roundKey, uint8_t* key);
void keyExpansion(uint8_t* roundKey, const uint8_t* key);
void cipher(state_t* state, uint8_t* roundKey);
void decipher(state_t* state, uint8_t* roundKey);
void subWord(uint8_t* word);
void rotWord(uint8_t* word);
void addRoundKey(uint8_t round, state_t* state, uint8_t* roundKey);
void addRoundKey(uint8_t round, state_t* state, const uint8_t* roundKey);
void blockXor(uint8_t* dst, uint8_t* a, uint8_t* b);
void blockLeftshift(uint8_t* dst, uint8_t* src);
void blockXor(uint8_t* dst, const uint8_t* a, const uint8_t* b);
void blockLeftshift(uint8_t* dst, const uint8_t* src);
void generateSubkeys(uint8_t* key1, uint8_t* key2);
void subBytes(state_t* state, const uint8_t* box);