From 9bd17bdb4cb5b3dcfae7341686a097e46fc873c3 Mon Sep 17 00:00:00 2001 From: jgromes Date: Thu, 23 Sep 2021 09:54:48 +0200 Subject: [PATCH] [RTTY] Remove call to standby after each byte (#306) --- examples/RTTY/RTTY_Transmit/RTTY_Transmit.ino | 3 +++ examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino | 3 +++ src/protocols/RTTY/RTTY.cpp | 2 -- src/protocols/RTTY/RTTY.h | 8 +++++++- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/RTTY/RTTY_Transmit/RTTY_Transmit.ino b/examples/RTTY/RTTY_Transmit/RTTY_Transmit.ino index 80c3c67f..f6d22a02 100644 --- a/examples/RTTY/RTTY_Transmit/RTTY_Transmit.ino +++ b/examples/RTTY/RTTY_Transmit/RTTY_Transmit.ino @@ -130,6 +130,9 @@ void loop() { float f = -3.1415; rtty.println(f, 3); + // turn the transmitter off + rtty.standby(); + Serial.println(F("done!")); // wait for a second before transmitting again diff --git a/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino b/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino index 23a66598..243c3488 100644 --- a/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino +++ b/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino @@ -123,6 +123,9 @@ void loop() { float f = -3.1415; rtty.println(f, 3); + // turn the transmitter off + rtty.standby(); + Serial.println(F("done!")); // wait for a second before transmitting again diff --git a/src/protocols/RTTY/RTTY.cpp b/src/protocols/RTTY/RTTY.cpp index f256e54b..15fc7a72 100644 --- a/src/protocols/RTTY/RTTY.cpp +++ b/src/protocols/RTTY/RTTY.cpp @@ -202,8 +202,6 @@ size_t RTTYClient::write(uint8_t b) { mark(); } - standby(); - return(1); } diff --git a/src/protocols/RTTY/RTTY.h b/src/protocols/RTTY/RTTY.h index ac8188e9..7bae7327 100644 --- a/src/protocols/RTTY/RTTY.h +++ b/src/protocols/RTTY/RTTY.h @@ -127,6 +127,13 @@ class RTTYClient { */ void idle(); + /*! + \brief Stops transmitting. + + \returns \ref status_codes + */ + int16_t standby(); + size_t write(const char* str); size_t write(uint8_t* buff, size_t len); size_t write(uint8_t b); @@ -178,7 +185,6 @@ class RTTYClient { size_t printFloat(double, uint8_t); int16_t transmitDirect(uint32_t freq = 0, uint32_t freqHz = 0); - int16_t standby(); }; #endif