From 7c3ed88c0d7697654e9fd2ec41479d489f286bd7 Mon Sep 17 00:00:00 2001 From: jgromes Date: Sat, 20 Jul 2024 16:41:13 +0200 Subject: [PATCH] [SX126x] Clarify DIO3 for AFSK-based examples --- examples/AFSK/AFSK_Imperial_March/AFSK_Imperial_March.ino | 2 +- examples/AFSK/AFSK_Tone/AFSK_Tone.ino | 2 +- examples/APRS/APRS_MicE/APRS_MicE.ino | 2 +- examples/APRS/APRS_Position/APRS_Position.ino | 2 +- examples/AX25/AX25_Transmit_AFSK/AX25_Transmit_AFSK.ino | 2 +- examples/BellModem/BellModem_Transmit/BellModem_Transmit.ino | 2 +- examples/FSK4/FSK4_Transmit_AFSK/FSK4_Transmit_AFSK.ino | 2 +- .../Hellschreiber_Transmit_AFSK.ino | 2 +- examples/Morse/Morse_Transmit_FM/Morse_Transmit_FM.ino | 2 +- examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino | 2 +- examples/SSTV/SSTV_Transmit_AFSK/SSTV_Transmit_AFSK.ino | 2 +- src/modules/SX126x/SX126x.cpp | 4 ++-- 12 files changed, 13 insertions(+), 13 deletions(-) diff --git a/examples/AFSK/AFSK_Imperial_March/AFSK_Imperial_March.ino b/examples/AFSK/AFSK_Imperial_March/AFSK_Imperial_March.ino index 0d905d6a..5b19bedf 100644 --- a/examples/AFSK/AFSK_Imperial_March/AFSK_Imperial_March.ino +++ b/examples/AFSK/AFSK_Imperial_March/AFSK_Imperial_March.ino @@ -9,7 +9,7 @@ - SX1231 - CC1101 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/AFSK/AFSK_Tone/AFSK_Tone.ino b/examples/AFSK/AFSK_Tone/AFSK_Tone.ino index 3071caf1..ad6738a1 100644 --- a/examples/AFSK/AFSK_Tone/AFSK_Tone.ino +++ b/examples/AFSK/AFSK_Tone/AFSK_Tone.ino @@ -10,7 +10,7 @@ - SX1231 - CC1101 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/APRS/APRS_MicE/APRS_MicE.ino b/examples/APRS/APRS_MicE/APRS_MicE.ino index aec26ec9..6500cac5 100644 --- a/examples/APRS/APRS_MicE/APRS_MicE.ino +++ b/examples/APRS/APRS_MicE/APRS_MicE.ino @@ -16,7 +16,7 @@ - CC1101 - nRF24 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/APRS/APRS_Position/APRS_Position.ino b/examples/APRS/APRS_Position/APRS_Position.ino index 06759f39..5b237af7 100644 --- a/examples/APRS/APRS_Position/APRS_Position.ino +++ b/examples/APRS/APRS_Position/APRS_Position.ino @@ -16,7 +16,7 @@ - CC1101 - nRF24 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/AX25/AX25_Transmit_AFSK/AX25_Transmit_AFSK.ino b/examples/AX25/AX25_Transmit_AFSK/AX25_Transmit_AFSK.ino index fb26775a..2b27bdc6 100644 --- a/examples/AX25/AX25_Transmit_AFSK/AX25_Transmit_AFSK.ino +++ b/examples/AX25/AX25_Transmit_AFSK/AX25_Transmit_AFSK.ino @@ -13,7 +13,7 @@ - CC1101 - nRF24 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/BellModem/BellModem_Transmit/BellModem_Transmit.ino b/examples/BellModem/BellModem_Transmit/BellModem_Transmit.ino index ec1b08f4..4b0e600e 100644 --- a/examples/BellModem/BellModem_Transmit/BellModem_Transmit.ino +++ b/examples/BellModem/BellModem_Transmit/BellModem_Transmit.ino @@ -33,7 +33,7 @@ SX1278 radio = new Module(10, 2, 9, 3); // SX1231: DIO2 // CC1101: GDO2 // Si443x/RFM2x: GPIO -// SX126x/LLCC68: DIO2 (only devices without TCXO!) +// SX126x/LLCC68: DIO2 BellClient bell(&radio, 5); void setup() { diff --git a/examples/FSK4/FSK4_Transmit_AFSK/FSK4_Transmit_AFSK.ino b/examples/FSK4/FSK4_Transmit_AFSK/FSK4_Transmit_AFSK.ino index f8c542fe..c31877b4 100644 --- a/examples/FSK4/FSK4_Transmit_AFSK/FSK4_Transmit_AFSK.ino +++ b/examples/FSK4/FSK4_Transmit_AFSK/FSK4_Transmit_AFSK.ino @@ -13,7 +13,7 @@ - SX1231 - CC1101 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/Hellschreiber/Hellschreiber_Transmit_AFSK/Hellschreiber_Transmit_AFSK.ino b/examples/Hellschreiber/Hellschreiber_Transmit_AFSK/Hellschreiber_Transmit_AFSK.ino index f6d5992c..77feff0d 100644 --- a/examples/Hellschreiber/Hellschreiber_Transmit_AFSK/Hellschreiber_Transmit_AFSK.ino +++ b/examples/Hellschreiber/Hellschreiber_Transmit_AFSK/Hellschreiber_Transmit_AFSK.ino @@ -12,7 +12,7 @@ - SX1231 - CC1101 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/Morse/Morse_Transmit_FM/Morse_Transmit_FM.ino b/examples/Morse/Morse_Transmit_FM/Morse_Transmit_FM.ino index 1de8baa8..de955cc6 100644 --- a/examples/Morse/Morse_Transmit_FM/Morse_Transmit_FM.ino +++ b/examples/Morse/Morse_Transmit_FM/Morse_Transmit_FM.ino @@ -12,7 +12,7 @@ - SX1231 - CC1101 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino b/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino index 70a798f3..cbeb0fe1 100644 --- a/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino +++ b/examples/RTTY/RTTY_Transmit_AFSK/RTTY_Transmit_AFSK.ino @@ -10,7 +10,7 @@ - SX1231 - CC1101 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 For default module settings, see the wiki page https://github.com/jgromes/RadioLib/wiki/Default-configuration diff --git a/examples/SSTV/SSTV_Transmit_AFSK/SSTV_Transmit_AFSK.ino b/examples/SSTV/SSTV_Transmit_AFSK/SSTV_Transmit_AFSK.ino index 5ec48a5a..85fe8de5 100644 --- a/examples/SSTV/SSTV_Transmit_AFSK/SSTV_Transmit_AFSK.ino +++ b/examples/SSTV/SSTV_Transmit_AFSK/SSTV_Transmit_AFSK.ino @@ -12,7 +12,7 @@ - SX1231 - CC1101 - Si443x/RFM2x - - SX126x/LLCC68 (only devices without TCXO!) + - SX126x/LLCC68 NOTE: Some platforms (such as Arduino Uno) might not be fast enough to correctly diff --git a/src/modules/SX126x/SX126x.cpp b/src/modules/SX126x/SX126x.cpp index 6b4cdda5..ceaccf29 100644 --- a/src/modules/SX126x/SX126x.cpp +++ b/src/modules/SX126x/SX126x.cpp @@ -345,8 +345,8 @@ int16_t SX126x::transmitDirect(uint32_t frf) { } RADIOLIB_ASSERT(state); - // start transmitting - uint8_t data[] = {RADIOLIB_SX126X_CMD_NOP}; + // direct mode activation intentionally skipped here, as it seems to lead to much worse results + uint8_t data[] = { RADIOLIB_SX126X_CMD_NOP }; return(this->mod->SPIwriteStream(RADIOLIB_SX126X_CMD_SET_TX_CONTINUOUS_WAVE, data, 1)); }