From 7a8cde1d38366b57300b9e1501d7d61ce7cc7386 Mon Sep 17 00:00:00 2001 From: jgromes Date: Sat, 4 Jul 2020 14:15:23 +0200 Subject: [PATCH] [ESP8266] Fixes from cppchekc scan --- src/modules/ESP8266/ESP8266.cpp | 6 +++--- src/modules/ESP8266/ESP8266.h | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/modules/ESP8266/ESP8266.cpp b/src/modules/ESP8266/ESP8266.cpp index 7cfef116..c7e23b00 100644 --- a/src/modules/ESP8266/ESP8266.cpp +++ b/src/modules/ESP8266/ESP8266.cpp @@ -83,9 +83,9 @@ int16_t ESP8266::join(const char* ssid, const char* password) { int16_t ESP8266::openTransportConnection(const char* host, const char* protocol, uint16_t port, uint16_t tcpKeepAlive) { char portStr[6]; - sprintf(portStr, "%d", port); + sprintf(portStr, "%u", port); char tcpKeepAliveStr[6]; - sprintf(tcpKeepAliveStr, "%d", tcpKeepAlive); + sprintf(tcpKeepAliveStr, "%u", tcpKeepAlive); // build AT command const char* atStr = "AT+CIPSTART=\""; @@ -132,7 +132,7 @@ int16_t ESP8266::closeTransportConnection() { int16_t ESP8266::send(const char* data) { // build AT command char lenStr[12]; - sprintf(lenStr, "%d", strlen(data)); + sprintf(lenStr, "%u", (uint16_t)strlen(data)); const char* atStr = "AT+CIPSEND="; #ifdef RADIOLIB_STATIC_ONLY char cmd[RADIOLIB_STATIC_ARRAY_SIZE]; diff --git a/src/modules/ESP8266/ESP8266.h b/src/modules/ESP8266/ESP8266.h index 4169f12f..eff7b8b0 100644 --- a/src/modules/ESP8266/ESP8266.h +++ b/src/modules/ESP8266/ESP8266.h @@ -48,12 +48,12 @@ class ESP8266: public TransportLayer { int16_t join(const char* ssid, const char* password); // transport layer methods (implementations of purely virtual methods in TransportLayer class) - int16_t openTransportConnection(const char* host, const char* protocol, uint16_t port, uint16_t tcpKeepAlive = 0); - int16_t closeTransportConnection(); - int16_t send(const char* data); - int16_t send(uint8_t* data, uint32_t len); - size_t receive(uint8_t* data, size_t len, uint32_t timeout = 10000); - size_t getNumBytes(uint32_t timeout = 10000, size_t minBytes = 10); + int16_t openTransportConnection(const char* host, const char* protocol, uint16_t port, uint16_t tcpKeepAlive = 0) override; + int16_t closeTransportConnection() override; + int16_t send(const char* data) override; + int16_t send(uint8_t* data, uint32_t len) override; + size_t receive(uint8_t* data, size_t len, uint32_t timeout = 10000) override; + size_t getNumBytes(uint32_t timeout = 10000, size_t minBytes = 10) override; #ifndef RADIOLIB_GODMODE private: