From 5bb98873644afe6e6180eb49fcd0a08916790da1 Mon Sep 17 00:00:00 2001 From: jgromes Date: Fri, 24 Sep 2021 08:48:23 +0200 Subject: [PATCH] Swapped SerialModule rst and serial arguments --- src/Module.cpp | 2 +- src/Module.h | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Module.cpp b/src/Module.cpp index ccf2e8fd..0d0dde53 100644 --- a/src/Module.cpp +++ b/src/Module.cpp @@ -1,6 +1,6 @@ #include "Module.h" -SerialModule::SerialModule(RADIOLIB_PIN_TYPE rx, RADIOLIB_PIN_TYPE tx, HardwareSerial* serial, RADIOLIB_PIN_TYPE rst): +SerialModule::SerialModule(RADIOLIB_PIN_TYPE rx, RADIOLIB_PIN_TYPE tx, RADIOLIB_PIN_TYPE rst, HardwareSerial* serial): Module(RADIOLIB_NC, RADIOLIB_NC, (RADIOLIB_PIN_TYPE)rst, (RADIOLIB_PIN_TYPE)rx, (RADIOLIB_PIN_TYPE)tx, RADIOLIB_DEFAULT_SPI, SPISettings(2000000, MSBFIRST, SPI_MODE0), NULL) { _initInterface = true; diff --git a/src/Module.h b/src/Module.h index a101fbdd..324c4e30 100644 --- a/src/Module.h +++ b/src/Module.h @@ -503,14 +503,14 @@ class SerialModule: public Module { \param tx Arduino pin to be used as Tx pin for SoftwareSerial communication. - \param serial HardwareSerial to be used on platforms that do not support SoftwareSerial. Defaults to Serial1. - \param rst Arduino pin to be used as hardware reset for the module. Defaults to NC (unused). + + \param serial HardwareSerial to be used on platforms that do not support SoftwareSerial. Defaults to Serial1. */ #ifdef RADIOLIB_SOFTWARE_SERIAL_UNSUPPORTED - SerialModule(RADIOLIB_PIN_TYPE rx, RADIOLIB_PIN_TYPE tx, HardwareSerial* serial = &RADIOLIB_HARDWARE_SERIAL_PORT, RADIOLIB_PIN_TYPE rst = RADIOLIB_NC); + SerialModule(RADIOLIB_PIN_TYPE rx, RADIOLIB_PIN_TYPE tx, RADIOLIB_PIN_TYPE rst = RADIOLIB_NC, HardwareSerial* serial = &RADIOLIB_HARDWARE_SERIAL_PORT); #else - SerialModule(RADIOLIB_PIN_TYPE rx, RADIOLIB_PIN_TYPE tx, HardwareSerial* serial = nullptr, RADIOLIB_PIN_TYPE rst = RADIOLIB_NC); + SerialModule(RADIOLIB_PIN_TYPE rx, RADIOLIB_PIN_TYPE tx, RADIOLIB_PIN_TYPE rst = RADIOLIB_NC, HardwareSerial* serial = nullptr); #endif };