From 208f4f8ad48d3cdac4830c97ed0d44aec9507bb6 Mon Sep 17 00:00:00 2001 From: jgromes Date: Sat, 18 Jan 2025 17:49:37 +0100 Subject: [PATCH] [Morse] Cppcheck fixes --- src/protocols/Morse/Morse.cpp | 6 ++++-- src/protocols/Morse/Morse.h | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/protocols/Morse/Morse.cpp b/src/protocols/Morse/Morse.cpp index c2ee4d74..6c4ffaf2 100644 --- a/src/protocols/Morse/Morse.cpp +++ b/src/protocols/Morse/Morse.cpp @@ -48,7 +48,8 @@ char MorseClient::decode(uint8_t symbol, uint8_t len) { // iterate over the table for(uint8_t i = 0; i < sizeof(MorseTable); i++) { - uint8_t code = RADIOLIB_NONVOLATILE_READ_BYTE(&MorseTable[i]); + uint8_t* ptr = const_cast(&MorseTable[i]); + uint8_t code = RADIOLIB_NONVOLATILE_READ_BYTE(ptr); if(code == symbol) { // match, return the index + ASCII offset return((char)(i + RADIOLIB_MORSE_ASCII_OFFSET)); @@ -129,7 +130,8 @@ size_t MorseClient::write(uint8_t b) { } // get morse code from lookup table - uint8_t code = RADIOLIB_NONVOLATILE_READ_BYTE(&MorseTable[(uint8_t)(toupper(b) - RADIOLIB_MORSE_ASCII_OFFSET)]); + uint8_t* ptr = const_cast(&MorseTable[(uint8_t)(toupper(b) - RADIOLIB_MORSE_ASCII_OFFSET)]); + uint8_t code = RADIOLIB_NONVOLATILE_READ_BYTE(ptr); // check unsupported characters if(code == RADIOLIB_MORSE_UNSUPPORTED) { diff --git a/src/protocols/Morse/Morse.h b/src/protocols/Morse/Morse.h index abc56890..ad491bce 100644 --- a/src/protocols/Morse/Morse.h +++ b/src/protocols/Morse/Morse.h @@ -172,8 +172,8 @@ class MorseClient: public RadioLibPrint { uint32_t pauseCounter = 0; RadioLibTime_t pauseStart = 0; - size_t printNumber(unsigned long, uint8_t); - size_t printFloat(double, uint8_t); + size_t printNumber(unsigned long, uint8_t) override; + size_t printFloat(double, uint8_t) override; int16_t transmitDirect(uint32_t freq = 0, uint32_t freqHz = 0); int16_t standby();