[EXT] Fixed issues found by cppcheck

This commit is contained in:
jgromes 2024-05-11 20:32:32 +01:00
parent 914c616c2a
commit 0f0ab73832

View file

@ -20,7 +20,7 @@ class ExternalRadio: public PhysicalLayer {
\brief Default constructor. \brief Default constructor.
\param pin Output pin when using direct transmission, defaults to unused pin. \param pin Output pin when using direct transmission, defaults to unused pin.
*/ */
ExternalRadio(uint32_t pin = RADIOLIB_NC); ExternalRadio(uint32_t pin = RADIOLIB_NC); // cppcheck-suppress noExplicitConstructor
#endif #endif
/*! /*!
@ -28,13 +28,13 @@ class ExternalRadio: public PhysicalLayer {
\param hal Pointer to the hardware abstraction layer to use. \param hal Pointer to the hardware abstraction layer to use.
\param pin Output pin when using direct transmission, defaults to unused pin. \param pin Output pin when using direct transmission, defaults to unused pin.
*/ */
ExternalRadio(RadioLibHal *hal, uint32_t pin = RADIOLIB_NC); ExternalRadio(RadioLibHal *hal, uint32_t pin = RADIOLIB_NC); // cppcheck-suppress noExplicitConstructor
/*! /*!
\brief Method to retrieve pointer to the underlying Module instance. \brief Method to retrieve pointer to the underlying Module instance.
\returns Pointer to the Module instance. \returns Pointer to the Module instance.
*/ */
Module* getMod(); Module* getMod() override;
/*! /*!
\brief Dummy implementation overriding PhysicalLayer. \brief Dummy implementation overriding PhysicalLayer.
@ -63,7 +63,7 @@ class ExternalRadio: public PhysicalLayer {
the output pin will be set to logic high. Otherwise it will be set to logic low. the output pin will be set to logic high. Otherwise it will be set to logic low.
\returns \ref status_codes \returns \ref status_codes
*/ */
int16_t transmitDirect(uint32_t frf = 0); int16_t transmitDirect(uint32_t frf = 0) override;
private: private:
Module* mod; Module* mod;