From 02bb36e1afdbb9b837b99ded8ecf5877ddc84648 Mon Sep 17 00:00:00 2001
From: jgromes <jgromes@users.noreply.github.com>
Date: Sat, 4 Jul 2020 15:26:55 +0200
Subject: [PATCH] [Hell] Fixes from cppcheck scan

---
 src/protocols/Hellschreiber/Hellschreiber.cpp | 3 ++-
 src/protocols/Hellschreiber/Hellschreiber.h   | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/protocols/Hellschreiber/Hellschreiber.cpp b/src/protocols/Hellschreiber/Hellschreiber.cpp
index 5c6483b3..d2355480 100644
--- a/src/protocols/Hellschreiber/Hellschreiber.cpp
+++ b/src/protocols/Hellschreiber/Hellschreiber.cpp
@@ -153,7 +153,8 @@ size_t HellClient::print(double n, int digits) {
 }
 
 size_t HellClient::println(void) {
-  return(0);
+  // Hellschreiber has no concept of "line ending", print one space instead
+  return(HellClient::print(' '));
 }
 
 size_t HellClient::println(__FlashStringHelper* fstr) {
diff --git a/src/protocols/Hellschreiber/Hellschreiber.h b/src/protocols/Hellschreiber/Hellschreiber.h
index a70e74e7..74eacb33 100644
--- a/src/protocols/Hellschreiber/Hellschreiber.h
+++ b/src/protocols/Hellschreiber/Hellschreiber.h
@@ -136,7 +136,7 @@ class HellClient {
 
     size_t println(void);
     size_t println(__FlashStringHelper*);
-    size_t println(const String &s);
+    size_t println(const String &);
     size_t println(const char[]);
     size_t println(char);
     size_t println(unsigned char, int = DEC);
@@ -156,8 +156,8 @@ class HellClient {
     void* _audio;
     #endif
 
-    uint32_t _base, _baseHz;
-    uint32_t _pixelDuration;
+    uint32_t _base = 0, _baseHz = 0;
+    uint32_t _pixelDuration = 0;
 
     size_t printNumber(unsigned long, uint8_t);
     size_t printFloat(double, uint8_t);